Move file struct to CLI
#2207
Merged
Move file struct to CLI
#2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
previously approved these changes
Feb 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2207 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 332 333 +1
Lines 7582 7584 +2
Branches 1175 1175
=======================================
+ Hits 7324 7326 +2
Misses 258 258 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Feb 21, 2024
FrederikBolding
force-pushed
the
fb/move-file-struct
branch
from
d547333
to
1752a78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
filestruct to the CLI package as it is the only place where it is currently in use.Previously it was part of the
snaps-utilsand even included in the browser entrypoint. This PR moves it to avoid that problem.