Add sizing limits for custom UI #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2199 +/- ##
=======================================
Coverage 96.58% 96.59%
=======================================
Files 332 332
Lines 7564 7582 +18
Branches 1171 1175 +4
=======================================
+ Hits 7306 7324 +18
Misses 258 258 ☔ View full report in Codecov by Sentry. |
FrederikBolding
commented
Feb 21, 2024
| import { nanoid } from 'nanoid'; | ||
|
|
||
| import { constructState } from './utils'; | ||
|
|
||
| const MAX_UI_CONTENT_SIZE = 256000; // 250 kb |
There was a problem hiding this comment.
This limit can probably be larger if we want it to be.
Mrtenz
requested changes
Feb 21, 2024
packages/snaps-utils/src/ui.ts
Outdated
| */ | ||
| export function getTotalTextLength(component: Component): number { | ||
| const { type } = component; | ||
| if (type === NodeType.Panel) { |
There was a problem hiding this comment.
Rows can contain text components too.
packages/snaps-controllers/src/interface/SnapInterfaceController.ts
Outdated
Show resolved
Hide resolved
Mrtenz
previously approved these changes
Feb 21, 2024
FrederikBolding
force-pushed
the
fb/ui-size-limits
branch
from
b43b7ca
to
636d88c
Compare
…er.ts Co-authored-by: Maarten Zuidhoorn <[email protected]>
FrederikBolding
force-pushed
the
fb/ui-size-limits
branch
from
636d88c
to
ebadbd3
Compare
Mrtenz
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sizing limits for custom UI input. Previously these inputs were only validated to have the proper formatting.
This PR adds logic to validate that the UI components provided by the Snap are within reasonable length. Both the entire UI component object is serialized to JSON and validated that it's total size is less than 250 kb. Also the total text used in the UI component is validated to be less than 50 kb.