Use error wrappers in all examples #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/use-snaperror-in-examples
branch
from
f722bc5
to
51aa8af
Compare
FrederikBolding
force-pushed
the
fb/use-snaperror-in-examples
branch
from
9e89099
to
56d5243
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2178 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 337 337
Lines 7622 7622
Branches 1183 1183
=======================================
Hits 7363 7363
Misses 259 259 ☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Mar 18, 2024
Mrtenz
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use error wrappers from the SDK in all examples, instead of recommending direct usage of
rpc-errors.Fixes #2041