Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce executor bundle sizes #2160

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Reduce executor bundle sizes #2160

merged 1 commit into from
Feb 5, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 5, 2024 •
edited
Loading

Reduce executor bundle sizes by tweaking a @metamask/providers import.

Before:

Finished node-thread (933 KB)
Finished node-process (933 KB)
Finished iframe (491 KB)
Finished worker-executor (945 KB)
Finished worker-pool (320 KB)

After:

Finished node-thread (816 KB)
Finished node-process (816 KB)
Finished iframe (383 KB)
Finished worker-executor (837 KB)
Finished worker-pool (320 KB)

Strips about 100 KB of unused code from the bundle.

@FrederikBolding FrederikBolding requested a review from a team as a code owner February 5, 2024 10:47
@FrederikBolding FrederikBolding merged commit 5ea4fb7 into main Feb 5, 2024
142 checks passed
@FrederikBolding FrederikBolding deleted the fb/reduce-executor-bundle-size branch February 5, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrederikBolding @Mrtenz