[BREAKING] Move endowments from Controllers to RPC methods #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david0xd
changed the title
david0xd
force-pushed
the
dd/move-endowments
branch
from
236178f
to
d2e674d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2155 +/- ##
=========================================
+ Coverage 0 96.68% +96.68%
=========================================
Files 0 324 +324
Lines 0 7305 +7305
Branches 0 1129 +1129
=========================================
+ Hits 0 7063 +7063
- Misses 0 242 +242 ☔ View full report in Codecov by Sentry. |
david0xd
force-pushed
the
dd/move-endowments
branch
from
46add89
to
abac6ce
Compare
Adjust coverage thresholds because of the moved files Adjust coverage thresholds in Controllers
david0xd
force-pushed
the
dd/move-endowments
branch
from
2227845
to
c6e35b5
Compare
FrederikBolding
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a BREAKING change because certain elements are moved from one package to another and import across the libraries is affected.
Summary of changes
All endowment related functionalities and specifications are moved from the
endowmentsfolder withinsnaps-controllersto theendowmentsfolder located undersnaps-rpc-methodspackage and exported from there.Export of certain functions from endowments required adjustments to the index files, so these changes are made as well.
Fixed are related imports of the endowments in another packages affected (e.g. snaps-simulator).
Code coverage thresholds are adjusted to the new calculations since there are no functional or logical changes.
Reasons for the changes
New features being implemented require endowment related specifications and functionalities, in different packages.
The example of this is Dynamic Permissions feature which require processing of the raw permission specification in order to request permission grant to the Permission Controller. This process requires specific utility functions as well as the caveat mappers or related specifications which cannot be imported from
snaps-controllerspackage directly into thesnaps-rpc-methodspackage.The best solution for now is to move the endowment related code to the
snaps-rpc-methodspackage and export it from there.