Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component validation to SnapInterfaceController #2144

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

GuillaumeRx
Copy link
Contributor

This updates SnapInterfaceController methods that handles content (createInterface and updateInterface) so that they validate the content passed (against the phishing list and the validity of the links for now).

The handlers return validation in SnapController has also been updated to only check the links if the content is passed directly.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner January 25, 2024 14:54
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12b4b2e) 96.79% compared to head (3b2533f) 96.78%.

❗ Current head 3b2533f differs from pull request most recent head 97364d3. Consider uploading reports for the commit 97364d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   96.79%   96.78%   -0.02%     
==========================================
  Files         325      324       -1     
  Lines        7292     7269      -23     
  Branches     1126     1126              
==========================================
- Hits         7058     7035      -23     
  Misses        234      234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuillaumeRx GuillaumeRx force-pushed the gr/add-phishing-check-interface branch from 8c85c91 to 97364d3 Compare January 26, 2024 09:47
@GuillaumeRx GuillaumeRx merged commit bdc833f into main Jan 26, 2024
144 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/add-phishing-check-interface branch January 26, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants