Set output.chunkFormat to commonjs by default
#2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmalik88
approved these changes
Jan 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 331 331
Lines 7459 7459
Branches 1145 1145
=======================================
Hits 7201 7201
Misses 258 258 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Jan 24, 2024
| * | ||
| * @see https://webpack.js.org/configuration/output/#outputchunkformat | ||
| */ | ||
| chunkFormat: 'commonjs', |
There was a problem hiding this comment.
Curious how this is needed when we don't do chunks 🤔
Does Webpack see our bundle as 1 chunk then and still applies whatever chunking rules?
|
Maarten has asked that we don't merge this yet until he looks into why it happens. |
Mrtenz
force-pushed
the
mrtenz/chunk-format-commonjs
branch
from
fe8d580
to
0367961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Webpack will use
JsonpChunkLoadingRuntimeModuleto load chunks. This injectsdocumentinto the Snap code, causing it to break. By settingoutput.chunkFormattocommonjs, we can disableJsonpChunkLoadingRuntimeModule.More context here: #2135