**BREAKING**: Update name lookup API #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
=======================================
Coverage 96.78% 96.79%
=======================================
Files 324 325 +1
Lines 7270 7292 +22
Branches 1126 1126
=======================================
+ Hits 7036 7058 +22
Misses 234 234 ☔ View full report in Codecov by Sentry. |
FrederikBolding
previously requested changes
Jan 22, 2024
packages/snaps-jest/src/internals/simulation/methods/specifications.test.ts
Outdated
Show resolved
Hide resolved
FrederikBolding
added a commit
that referenced
this pull request
Jan 22, 2024
Add a utility function for validating caveat types for a permission. This lets us generically validate permissions with multiple caveat types without duplicating validation code across the permission specifications. This is useful long-term as we add more permissions that have more than 1 caveat type. This is a prerequisite for #2113 and #2098
FrederikBolding
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing API was not in accordance with SIP-12 and with further updates to the spec, an update was needed to bring things into parity.