Add a link to confirmation dialog in dialog example snap #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 313 313
Lines 7062 7062
Branches 1108 1108
=======================================
Hits 6827 6827
Misses 235 235 ☔ View full report in Codecov by Sentry. |
| @@ -47,7 +47,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => { | |||
| content: panel([ | |||
| heading('Confirmation Dialog'), | |||
| text( | |||
| 'This is a confirmation dialog. It has two buttons: "OK" and "Cancel," letting the user choose whether to proceed with an action.', | |||
| 'This is a confirmation dialog. It has two buttons: "OK" and "Cancel," letting the user choose whether to proceed with an action. [That](https://snaps.metamask.io/) is a what a link looks like.', | |||
There was a problem hiding this comment.
You need to update tests as well since you've changed the UI displayed!
There was a problem hiding this comment.
This was fixed in the latest commit.
FrederikBolding
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a link to the confirmation dialog for UI link testing purposes.