Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SES and LavaMoat #2105

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Bump SES and LavaMoat #2105

merged 5 commits into from
Jan 18, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 18, 2024

Bumps all LavaMoat packages to their latest versions.

This solves a problem where the snaps execution environment would fail to function in the latest version of Chrome Canary. It also means we can remove some of our patches as some changes have been upstreamed!

Copy link

socket-security bot commented Jan 18, 2024

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@lavamoat/lavapack 5.4.1...6.0.2 None +8/-8 2.67 MB
lavamoat-browserify 15.9.1...17.0.2 None +12/-14 3.23 MB
lavamoat 7.3.1...8.0.2 None +16/-8 2.37 MB
@lavamoat/lavatube 0.2.3...1.0.0 None +0/-0 40.6 kB kumavis
@lavamoat/allow-scripts 2.5.1...3.0.1 None +82/-82 1.59 MB
ses 0.18.8...1.1.0 None +3/-3 3.28 MB kriskowal

Copy link

socket-security bot commented Jan 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @lavamoat/[email protected], [email protected], [email protected], @lavamoat/[email protected], @lavamoat/[email protected], [email protected], @lavamoat/[email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@@ -24,14 +24,14 @@ import { SILENT_LOGGER } from './logger';
*/
export function walkAndSearch(subject: unknown, target: unknown) {
let result = false;
const walker = new LavaTube(
walk(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this API changed with the release of LavaTube.

@weizman Could you take a quick look and verify this usage is still fine?

// shows the full call stack
stackFiltering: 'verbose',
+ // prevent issues when dealing with the "override mistake"
+ overrideTaming: 'severe',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been upstreamed to LavaMoat, simplifying our patches!

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f87b45a) 96.65% compared to head (3470e1b) 96.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2105   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files         312      312           
  Lines        7023     7023           
  Branches     1101     1101           
=======================================
  Hits         6788     6788           
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizman
weizman previously approved these changes Jan 18, 2024
Copy link
Member

@weizman weizman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval lavatube upgrade

@FrederikBolding FrederikBolding marked this pull request as ready for review January 18, 2024 14:01
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 18, 2024 14:01
@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore @lavamoat/[email protected]
@SocketSecurity ignore [email protected]

Author is trusted!

@SocketSecurity ignore [email protected]
@SocketSecurity ignore @lavamoat/[email protected]
@SocketSecurity ignore @lavamoat/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @lavamoat/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Packages were just published and are thus marked as "unpublished"

@FrederikBolding FrederikBolding merged commit fbef4f1 into main Jan 18, 2024
144 checks passed
@FrederikBolding FrederikBolding deleted the fb/bump-ses-and-lavamoat branch January 18, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants