-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SES and LavaMoat #2105
Bump SES and LavaMoat #2105
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@@ -24,14 +24,14 @@ import { SILENT_LOGGER } from './logger'; | |||
*/ | |||
export function walkAndSearch(subject: unknown, target: unknown) { | |||
let result = false; | |||
const walker = new LavaTube( | |||
walk( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this API changed with the release of LavaTube.
@weizman Could you take a quick look and verify this usage is still fine?
// shows the full call stack | ||
stackFiltering: 'verbose', | ||
+ // prevent issues when dealing with the "override mistake" | ||
+ overrideTaming: 'severe', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been upstreamed to LavaMoat, simplifying our patches!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2105 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 312 312
Lines 7023 7023
Branches 1101 1101
=======================================
Hits 6788 6788
Misses 235 235 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval lavatube upgrade
@SocketSecurity ignore @lavamoat/[email protected] Author is trusted! @SocketSecurity ignore [email protected] Packages were just published and are thus marked as "unpublished" |
Bumps all LavaMoat packages to their latest versions.
This solves a problem where the snaps execution environment would fail to function in the latest version of Chrome Canary. It also means we can remove some of our patches as some changes have been upstreamed!