Add more install events #2087
Merged
Add more install events #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2087 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 312 312
Lines 7016 7020 +4
Branches 1101 1101
=======================================
+ Hits 6781 6785 +4
Misses 235 235 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/add-install-events
branch
from
8412eb7 to
2fe385a
Compare
Mrtenz
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
:snapInstallStartedwhich is emitted once connection to a snap has been completed and the actual installation or update starts. Also adds:snapInstallFailedwhich is emitted if the installation or update started fails any step of the installation process (excluding connection).Progresses https://github.com/MetaMask/MetaMask-planning/issues/1839