Signature insight example + type fix #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
=======================================
Coverage ? 96.32%
=======================================
Files ? 271
Lines ? 6399
Branches ? 1043
=======================================
Hits ? 6164
Misses ? 235
Partials ? 0 ☔ View full report in Codecov by Sentry. |
hmalik88
changed the title
Mrtenz
requested changes
Jan 9, 2024
Mrtenz
approved these changes
Jan 10, 2024
ritave
reviewed
Jan 10, 2024
| /** | ||
| * The MetaMask test dapp uses the below contract address as the verifying | ||
| * contract for `eth_signTypedData_v3` and `eth_signTypedData_v4`, it is being | ||
| * used here as a flag to return content and to make e2e testing easier in the extension. |
There was a problem hiding this comment.
Can you provide a permanent link to where this contract is set-up
There was a problem hiding this comment.
It's a dummy contract address, I guess I should have specified that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2077
eth_signTypedDatasignature definition.