Populate subject metadata #2069
Conversation
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
FrederikBolding
force-pushed
the
fb/populate-subject-metadata
branch
from
a9a66a4 to
cbefc8a
Compare
|
@SocketSecurity ignore @metamask/[email protected] This package has been published, I promise Socket. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2069 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 270 270
Lines 6300 6303 +3
Branches 1017 1018 +1
=======================================
+ Hits 6066 6069 +3
Misses 234 234 ☔ View full report in Codecov by Sentry. |
| @@ -2345,12 +2347,23 @@ export class SnapController extends BaseController< | |||
| } | |||
| } | |||
|
|
|||
| const stringifiedIcon = svgIcon?.toString(); | |||
|
|
|||
| // TODO: Consider removing this as it is unused now | |||
There was a problem hiding this comment.
I'm wasn't sure if there is another use-case for the :snapAdded event. I was gonna post in Slack to have a short discussion on it and go from there
Following #2069 we can now remove the `snapAdded` event as it doesn't have a use-case anymore.
Populate subject metadata in the SnapController, allowing us to reduce code duplication in clients of the following snippet: https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/metamask-controller.js#L2367-L2373
This change is also required for preinstalled snaps to work.