Fix issues with using proxy executors #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot update-pr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2045 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 270 270
Lines 6310 6310
Branches 1023 1023
=======================================
Hits 6072 6072
Misses 238 238 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/fix-offscreen-executor
branch
from
6c1af2b
to
aa84ac1
Compare
FrederikBolding
changed the title
Mrtenz
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iframe utility export to execution environment entry point, to be used by mobile and offscreen environments.
By request of @naugtur also moves the bundle.js to the body of the execution env HTML.