-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor NpmLocation
class
#2038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2038 +/- ##
==========================================
+ Coverage 96.13% 96.22% +0.09%
==========================================
Files 270 270
Lines 6309 6310 +1
Branches 1023 1023
==========================================
+ Hits 6065 6072 +7
+ Misses 244 238 -6 ☔ View full report in Codecov by Sentry. |
FrederikBolding
changed the title
Refactor NPM location class
Refactor Dec 15, 2023
NpmLocation
class
Mrtenz
requested changes
Dec 15, 2023
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
reviewed
Dec 18, 2023
Mrtenz
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
NpmLocation
to move most logic to aBaseNpmLocation
class that can be extended in the mobile client. A class extending the base class only need to implementfetchNpmTarball
reducing code duplication. As part of this refactor I've also simplified the implementation in multiple places and improved the coverage.Fixes #2040