Improve SnapController constructor typing
#2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 269 269
Lines 6261 6262 +1
Branches 1009 1010 +1
=======================================
+ Hits 6016 6017 +1
Misses 245 245 ☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Dec 8, 2023
Mrtenz
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve SnapController constructor typing to improve compatibility with mobile. Most of the constructor arguments have sane defaults provided by the SnapController itself and are therefore allowed to be undefined. The feature flags are also allowed to be true, false and undefined.
These issues weren't caught until now because the extension integration is not typed.