Add support for preinstalled snaps #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/preinstalled-snaps
branch
from
ba4efa4
to
195f44c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 271 271
Lines 6361 6399 +38
Branches 1034 1043 +9
=======================================
+ Hits 6127 6164 +37
- Misses 234 235 +1 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/preinstalled-snaps
branch
from
b7dc178
to
dc260b3
Compare
FrederikBolding
force-pushed
the
fb/preinstalled-snaps
branch
2 times, most recently
from
e1d2107
to
8e597af
Compare
Mrtenz
requested changes
Jan 9, 2024
FrederikBolding
force-pushed
the
fb/preinstalled-snaps
branch
from
33a93ee
to
1da38a5
Compare
FrederikBolding
force-pushed
the
fb/preinstalled-snaps
branch
from
2383bf6
to
c61303f
Compare
Mrtenz
approved these changes
Jan 10, 2024
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the notion of preinstalled snaps, these are snaps that will be automatically inserted into the SnapController state on boot and made available for execution. This proves useful for platforms where installing arbitrary snaps is not supported or for shipping MetaMask-built functionality as snaps.
Closes https://github.com/MetaMask/MetaMask-planning/issues/1742