Loosen allowlist requirements #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/less-restrictive-allowlist
branch
from
e401315
to
1c2b700
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 326 327 +1
Lines 7326 7331 +5
Branches 1129 1130 +1
=======================================
+ Hits 7092 7097 +5
Misses 234 234 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/less-restrictive-allowlist
branch
from
e8aa999
to
da68517
Compare
Montoya
reviewed
Feb 1, 2024
There was a problem hiding this comment.
It's happening! 🎉
hmalik88
previously approved these changes
Feb 1, 2024
ritave
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows snaps with certain permissions to be installed without being on the allowlist even when the allowlist feature flag is set.