Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement snap_getInterfaceContext #2901

Closed
FrederikBolding opened this issue Nov 21, 2024 · 0 comments · Fixed by MetaMask/metamask-extension#28678
Closed

Implement snap_getInterfaceContext #2901

FrederikBolding opened this issue Nov 21, 2024 · 0 comments · Fixed by MetaMask/metamask-extension#28678
Assignees
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0

Comments

@FrederikBolding
Copy link
Member

Expose snap_getInterfaceContext to make the context easily available outside onUserInput

@FrederikBolding FrederikBolding self-assigned this Nov 21, 2024
FrederikBolding added a commit that referenced this issue Nov 22, 2024
Expose a new RPC method `snap_getInterfaceContext` that makes the
`context` easily accessible outside `onUserInput`. Also adds the
necessary wiring to make this RPC method work in the simulation
environment.

This feature will require the addition of a `getInterfaceContext` method
hook in the clients.

Progresses #2901
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this issue Nov 25, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:
- Add `snap_getInterfaceContext` JSON-RPC method
- Emit `snapInstalled` and `snapUpdated` events for preinstalled Snaps
- This indirectly makes preinstalled Snaps trigger cronjobs and
lifecycle hooks more reliably.

Closes MetaMask/snaps#2899
Closes MetaMask/snaps#2901

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28678?quickstart=1)
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this issue Nov 26, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:
- Add `snap_getInterfaceContext` JSON-RPC method
- Emit `snapInstalled` and `snapUpdated` events for preinstalled Snaps
- This indirectly makes preinstalled Snaps trigger cronjobs and
lifecycle hooks more reliably.

Closes MetaMask/snaps#2899
Closes MetaMask/snaps#2901

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28678?quickstart=1)
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
cmd-ob pushed a commit to MetaMask/metamask-extension that referenced this issue Nov 26, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:
- Add `snap_getInterfaceContext` JSON-RPC method
- Emit `snapInstalled` and `snapUpdated` events for preinstalled Snaps
- This indirectly makes preinstalled Snaps trigger cronjobs and
lifecycle hooks more reliably.

Closes MetaMask/snaps#2899
Closes MetaMask/snaps#2901

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28678?quickstart=1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants