Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show permissions on Snap details page #255

Merged
merged 16 commits into from
Feb 7, 2024
Merged

Show permissions on Snap details page #255

merged 16 commits into from
Feb 7, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Dec 11, 2023 •
edited
Loading

This adds permissions to the Snap details page.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited
Loading

Commit abb941e0453082cb43a74a24bb7e3edb207c2b6c successfully pushed to staging website:

https://metamask.github.io/snaps-directory-staging/pr/255/

@eriknson eriknson mentioned this pull request Jan 15, 2024
Closed
@Mrtenz Mrtenz force-pushed the mrtenz/permissions branch from 3430cc4 to ae472cc Compare January 18, 2024 10:18
@Mrtenz Mrtenz marked this pull request as ready for review January 18, 2024 14:53
@Mrtenz Mrtenz requested a review from a team as a code owner January 18, 2024 14:53
FrederikBolding
FrederikBolding reviewed Jan 19, 2024
View reviewed changes
src/features/snap/permissions.tsx Show resolved Hide resolved
src/features/snap/components/Permissions.tsx Show resolved Hide resolved
src/features/snap/permissions.tsx Outdated Show resolved Hide resolved
src/features/snap/permissions.tsx Show resolved Hide resolved
@Mrtenz Mrtenz marked this pull request as draft January 22, 2024 11:50
@Mrtenz Mrtenz force-pushed the mrtenz/permissions branch from e5d1f02 to 1807e4f Compare February 7, 2024 11:26
@Mrtenz Mrtenz marked this pull request as ready for review February 7, 2024 11:27
@Mrtenz Mrtenz merged commit ad6d679 into main Feb 7, 2024
16 checks passed
@Mrtenz Mrtenz deleted the mrtenz/permissions branch February 7, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees

@Mrtenz Mrtenz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mrtenz @FrederikBolding