Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ethers with submodules #95

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Replace ethers with submodules #95

merged 2 commits into from
Sep 9, 2022

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Sep 8, 2022 •
edited
Loading

This is MetaMask/metamask-extension#15461 to remove any ethers submodules that are not used in the extension dependency tree by replacing all imports of ethers for the used submodule itself

CHANGED:

  • Simply replaces the "umbrella" version of ethers with the submodules that we actually use: @ethersproject/bytes , @ethersproject/providers & @ethersproject/bignumber.

@adonesky1 adonesky1 requested a review from a team as a code owner September 8, 2022 22:43
@adonesky1 adonesky1 changed the title Replace ethers with submodules Replace ethers with submodules Sep 8, 2022
@adonesky1 adonesky1 force-pushed the replace-ethers-with-submodules branch from f745ac9 to ceac6bf Compare September 9, 2022 14:43
@adonesky1 adonesky1 force-pushed the replace-ethers-with-submodules branch from 43448a8 to c1b61cc Compare September 9, 2022 15:02
darkwing
darkwing approved these changes Sep 9, 2022
View reviewed changes
Copy link

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @adonesky1 !

dan437
dan437 approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@dan437 dan437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working, LGTM.

@adonesky1 adonesky1 merged commit e23705d into main Sep 9, 2022
@adonesky1 adonesky1 deleted the replace-ethers-with-submodules branch September 9, 2022 15:45
@adonesky1 adonesky1 mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan437 dan437 dan437 approved these changes

@darkwing darkwing darkwing approved these changes

@wachunei wachunei Awaiting requested review from wachunei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adonesky1 @darkwing @dan437