Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config for MetaMask/action-npm-publish #85

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Add config for MetaMask/action-npm-publish #85

merged 1 commit into from
Jul 20, 2022

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Jul 14, 2022 •
edited
Loading

This PR adds config so that we can automatically deploy packages to npm on release.

Opening as a Draft for now until the environment (npm-publish) is configured.

I've tested this in my fork here: https://github.com/rickycodes/smart-transactions-controller/actions/runs/2667509178

TODO:

  • set up npm-publish environment with NPM_TOKEN secret

@rickycodes rickycodes requested a review from a team as a code owner July 14, 2022 02:22
@rickycodes rickycodes marked this pull request as draft July 14, 2022 02:22
@rickycodes rickycodes mentioned this pull request Jul 15, 2022
Closed
@rickycodes rickycodes marked this pull request as ready for review July 19, 2022 20:58
dan437
dan437 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@dan437 dan437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rickycodes rickycodes merged commit bc54808 into main Jul 20, 2022
@rickycodes rickycodes deleted the feature/npm-publish branch July 20, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan437 dan437 dan437 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickycodes @dan437