Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all error props in an error response #82

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Conversation

dan437
Copy link
Collaborator

@dan437 dan437 commented Jul 8, 2022

Description

Since we started getting additional error props (e.g. balance_needed_wei or current_balance_wei), we need to return them as well, so UI can use them.

I made sure we return them in our standardised camelCase format.

@dan437 dan437 requested a review from a team as a code owner July 8, 2022 14:44
Copy link
Contributor

@meppsilon meppsilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good sir

@dan437 dan437 merged commit 1d23798 into main Jul 11, 2022
@dan437 dan437 deleted the return-all-error-props branch July 11, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants