Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"estimateGas" -> "getFees", support a new cancellation reason, refactoring #69

Merged
merged 6 commits into from
May 17, 2022

Conversation

dan437
Copy link
Collaborator

@dan437 dan437 commented May 16, 2022

Description

This PR includes:

  • Support for a new cancellation reason: PREVIOUS_TX_CANCELLED
  • Get approval and trade fees within one API call via getFees
  • Remove code related to "estimatedGas", update UTs for "getFees", refactoring

@dan437 dan437 requested a review from a team as a code owner May 16, 2022 11:57
@dan437 dan437 merged commit ee73b8d into main May 17, 2022
@dan437 dan437 deleted the stx-controller-improvements branch May 17, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants