Remove test-helpers from build #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
standardize-tsconfigs
branch
3 times, most recently
from
b48e7e5
to
f25cf96
Compare
The test helpers file is showing up in the published package when it should not be. This commit moves it to a directory that is automatically excluded by the TypeScript configuration.
mcmire
force-pushed
the
remove-test-files-from-build
branch
from
8c485a5
to
9ae2ce9
Compare
|
We need to reduce coverage thresholds to account for removing the test helpers (they were previously considered as code under test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test helpers file is showing up in the published package when it should not be. This commit moves it to a directory that is automatically excluded by the TypeScript configuration.
Manual Testing
distif presentyarn builddist