Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new function "wipeSmartTransactions", replace Goerli with Sepolia #316

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

dan437
Copy link
Collaborator

@dan437 dan437 commented Apr 15, 2024

Description

This PR does 2 things:

  • Adds a new function "wipeSmartTransactions"
  • Replaces Goerli with Sepolia

The "wipeSmartTransactions" function is needed when a user wants to clear their Activity in MM. It's done similarly to what's implemented in the TransactionController.

@dan437 dan437 requested a review from a team as a code owner April 15, 2024 14:30
@legobeat
Copy link
Contributor

legobeat commented Apr 19, 2024

Can this PR be split into two PRs?

  • One for "Replace Goerli with Sepolia"
  • One for the new feature wipeSmartTransactions

The two don't seem inherently related?

@dan437
Copy link
Collaborator Author

dan437 commented Apr 23, 2024

Hi @legobeat, I wanted to have tests for the new wipeSmartTransactions function using Sepolia instead of Goerli, since we don't use Goerli anymore for Smart Transactions and use Sepolia and Ethereum Mainnet instead. That's why I would prefer to keep it together in one PR.

@dan437 dan437 merged commit ad91b16 into main Apr 23, 2024
16 checks passed
@dan437 dan437 deleted the stx-wipe-txs branch April 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants