Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock submit transaction if ethers errors #30

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Unblock submit transaction if ethers errors #30

merged 1 commit into from
Dec 3, 2021

Conversation

meppsilon
Copy link
Contributor

No description provided.

@meppsilon meppsilon requested a review from a team as a code owner December 2, 2021 21:23
dan437
dan437 reviewed Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@dan437 dan437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Have you tried to fail things in the try block on purpose and see if STX submit works?

@dan437 dan437 merged commit cf6565d into main Dec 3, 2021
@dan437 dan437 deleted the unblock-ethers branch December 3, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan437 dan437 dan437 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meppsilon @dan437