Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit an event after a tx is confirmed, remove "skipConfirm", return "txHash" #298

Merged
merged 9 commits into from
Mar 19, 2024

Conversation

dan437
Copy link
Collaborator

@dan437 dan437 commented Mar 18, 2024

Description

This PR includes multiple things:

  • Emit an event after a tx is confirmed
  • Remove "skipConfirm"
  • Return "txHash"
  • Change to: public eventEmitter: EventEmitter;

@dan437 dan437 requested a review from a team as a code owner March 18, 2024 14:24
Copy link

socket-security bot commented Mar 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ethereumjs/[email protected] Transitive: network +8 4.09 MB holgerd77
npm/@ethereumjs/[email protected] None 0 134 kB holgerd77
npm/@ethereumjs/[email protected] Transitive: network +9 4.75 MB holgerd77
npm/@ethereumjs/[email protected] network +7 3.43 MB holgerd77
npm/@types/[email protected] None +1 1.8 MB types
npm/@types/[email protected] None +1 1.79 MB types
npm/@types/[email protected] None +1 1.79 MB types
npm/[email protected] None +1 41.6 kB junderw
npm/[email protected] None 0 160 kB dcposch
npm/[email protected] None 0 3.52 kB indutny
npm/[email protected] Transitive: environment +13 287 kB cwmma
npm/[email protected] None +2 46.2 kB dcousens
npm/[email protected] Transitive: environment +13 267 kB dcousens
npm/[email protected] None 0 4.83 kB dcousens
npm/[email protected] None +2 44 kB cwmma
npm/[email protected] Transitive: environment +10 248 kB cwmma
npm/[email protected] Transitive: environment +11 254 kB cwmma
npm/[email protected] None +7 295 kB indutny
npm/[email protected] Transitive: environment, filesystem +41 7.63 MB holgerd77
npm/[email protected] Transitive: environment +7 199 kB dcousens
npm/[email protected] Transitive: environment +5 186 kB fanatid
npm/[email protected] None +2 47.2 kB indutny
npm/[email protected] None +4 76.9 kB indutny
npm/[email protected] None 0 13.6 kB indutny
npm/[email protected] Transitive: environment, filesystem +7 1.77 MB fanatid
npm/[email protected] Transitive: environment +6 194 kB cwmma
npm/[email protected] None 0 1.55 kB cwmma
npm/[email protected] None 0 4.76 kB indutny
npm/[email protected] None 0 799 kB nicknaso
npm/[email protected] environment, filesystem 0 13.4 kB mafintosh
npm/[email protected] Transitive: environment +12 267 kB cwmma
npm/[email protected] None +1 38.5 kB cwmma
npm/[email protected] Transitive: environment +6 196 kB dcousens
npm/[email protected] None +1 162 kB ralxz
npm/[email protected] None 0 226 kB ricmoo
npm/[email protected] Transitive: environment, filesystem +10 3 MB fanatid
npm/[email protected] None 0 8.56 kB domenic
npm/[email protected] None +2 67.1 kB dcousens

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Mar 18, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Mild CVE npm/[email protected]
New author npm/[email protected]
New author npm/[email protected]
New author npm/[email protected]
New author npm/[email protected]
Native code npm/[email protected]
Native code npm/[email protected]
Network access npm/@ethereumjs/[email protected]

View full report↗︎

Next steps

What is a mild CVE?

Contains a low severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@dan437 dan437 merged commit aed85b9 into main Mar 19, 2024
15 of 16 checks passed
@dan437 dan437 deleted the stx-updates-1 branch March 19, 2024 10:08
@legobeat legobeat mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants