Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stx controller version #227

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Stx controller version #227

merged 4 commits into from
Nov 7, 2023

Conversation

dan437
Copy link
Collaborator

@dan437 dan437 commented Nov 7, 2023 •
edited
Loading

Description

Add the "stxControllerVersion" query param for the /submitTransactions API call. That's because then backend can have custom logic based on the version.

@dan437 dan437 requested a review from a team as a code owner November 7, 2023 16:21
infiniteflower
infiniteflower approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@infiniteflower infiniteflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan437 dan437 merged commit 0682c61 into main Nov 7, 2023
17 checks passed
@dan437 dan437 deleted the stx-controller-version branch November 7, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiniteflower infiniteflower infiniteflower approved these changes

@cloudonshore cloudonshore cloudonshore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan437 @cloudonshore @infiniteflower