Add cancelled status to stx after successful cancel request #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan437
reviewed
Nov 10, 2021
|
|
||
| this.updateSmartTransaction({ | ||
| uuid, | ||
| status: SmartTransactionStatuses.CANCELLED_USER_CANCELLED, |
There was a problem hiding this comment.
I think that even if a user tries to cancel a transaction, it might be too late sometimes and it could get mined. At least that's how it works with regular transactions. Maybe this is fine if we hide the cancel buttons after 10s, otherwise we could just rely on what we get from backend.
There was a problem hiding this comment.
Does backend respond with a status that indicates if the transaction was able to be cancelled?
There was a problem hiding this comment.
Yes, backend should return a specific status if a transaction was successfully canceled by a user / automatically.
dan437
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.