Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0.0 #202

Merged
merged 3 commits into from
Oct 2, 2023
Merged

5.0.0 #202

merged 3 commits into from
Oct 2, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 5.0.0.

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/[email protected]

@jiexi jiexi marked this pull request as ready for review September 27, 2023 16:54
@jiexi jiexi requested a review from a team as a code owner September 27, 2023 16:54
@jiexi jiexi mentioned this pull request Sep 27, 2023
Merged
8 tasks
legobeat
legobeat reviewed Sep 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
legobeat
legobeat reviewed Sep 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
legobeat
legobeat previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs an entry for #191

@jiexi
Copy link
Contributor

jiexi commented Oct 2, 2023

@legobeat there should be changelog for #191 already here https://github.com/MetaMask/smart-transactions-controller/pull/202/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edL13-R17

@jiexi jiexi requested a review from legobeat October 2, 2023 17:28
@legobeat
Copy link
Contributor

legobeat commented Oct 2, 2023

@legobeat there should be changelog for #191 already here https://github.com/MetaMask/smart-transactions-controller/pull/202/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edL13-R17

Ah I see, they were buried under the Uncategorized that were since removed in 4546355 👍

adonesky1
adonesky1 reviewed Oct 2, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
adonesky1
adonesky1 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiexi jiexi merged commit 4cae857 into main Oct 2, 2023
16 checks passed
@jiexi jiexi deleted the release/5.0.0 branch October 2, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiexi jiexi jiexi left review comments

@adonesky1 adonesky1 adonesky1 approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@mcmire mcmire Awaiting requested review from mcmire

@legobeat legobeat Awaiting requested review from legobeat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiexi @legobeat @adonesky1