Skip to content

Tracking of STX status changes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2021
Merged

Tracking of STX status changes #20

merged 4 commits into from
Nov 10, 2021

Conversation

dan437
Copy link
Collaborator

@dan437 dan437 commented Nov 9, 2021

No description provided.

@dan437 dan437 requested a review from a team as a code owner November 9, 2021 18:38
@@ -198,8 +244,16 @@ export default class SmartTransactionsController extends BaseController<
const currentIndex = currentSmartTransactions?.findIndex(
(st) => st.uuid === smartTransaction.uuid,
);
const isNewSmartTransaction =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@meppsilon meppsilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there any other transaction updates that we would like to track, particularly on creation or confirmation?

* @param {number} smartTransactionSubmittedtime
* @returns {number} Processing time in seconds.
*/
export const getStxProcessingTime = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dan437 dan437 merged commit dfb4a45 into main Nov 10, 2021
@dan437 dan437 deleted the tracking branch November 10, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants