Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: @metamask/* updates #131

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 24, 2023

Changes

  • Remove isomorphic-fetch from runtime dependencies - runtime lacking fetch implementation now have to supply their own polyfill.
  • Upgrade packages
    • @metamask/base-controller@1.0.0->2.0.0
    • @metamask/controller-utils@1.0.0->3.3.0
    • @metamask/network-controller@2.0.0->7.0.0

Unifies:

@legobeat legobeat requested a review from a team as a code owner April 24, 2023 10:59
@legobeat legobeat marked this pull request as draft April 24, 2023 10:59
@socket-security
Copy link

socket-security bot commented Apr 24, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@metamask/[email protected] 1.1.1...2.0.0 network +21/-1 metamaskbot
@metamask/[email protected] 2.0.0...7.0.0 None +24/-2 metamaskbot
@metamask/[email protected] 1.0.0...3.3.0 network +20/-0 metamaskbot
[email protected] 13.1.3...13.3.0 None +0/-1 nockbot

@legobeat legobeat force-pushed the deps-metamask-controller-updates branch 2 times, most recently from 4a5a851 to db4e00c Compare April 24, 2023 11:05
@legobeat legobeat marked this pull request as ready for review April 24, 2023 11:06
@legobeat legobeat force-pushed the deps-metamask-controller-updates branch from db4e00c to 2769958 Compare April 24, 2023 11:08
@legobeat legobeat requested a review from adonesky1 April 24, 2023 11:50
Gudahtt
Gudahtt previously approved these changes Apr 24, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this, I've been meaning to update these for a while

@legobeat legobeat force-pushed the deps-metamask-controller-updates branch from 2769958 to 502cbd1 Compare April 24, 2023 12:28
@legobeat legobeat requested a review from Gudahtt April 24, 2023 12:28
@legobeat legobeat merged commit 58c393b into MetaMask:main Apr 24, 2023
@Gudahtt Gudahtt mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants