chore: include regular tx events during the stx status changes #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tagging @forest-diggs-consensys and @John.Brennan for visibility since they have been part of the conversations around this update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular Swaps fire a ‘transaction submitted’ event, but we aren’t currently triggering this event when a Smart Transaction is submitted.
While the regular tx and an stx go through different flows, we need to map regular tx events to events fired during stx statuses updates, while still keeping STX custom events.
This PR adds
Transaction SubmittedandTransaction Finalized(in the event that the STX is cancelled)Made this flow chart so its easier to understand at which point in time these events are included.
More info in: MMS-393