Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @metamask/controllers from 32.0.2 to 33.0.0 #107

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 9, 2022

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps @metamask/controllers from 32.0.2 to 33.0.0.

Release notes

Sourced from @​metamask/controllers's releases.

33.0.0

Added

  • Add clear function for NotificationController (#943)

Changed

  • BREAKING: Rename "Collectible" to "NFT" (#934)
    • Rename CollectiblesController to NftController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".
    • Rename CollectibleDetectionController to NftDetectionController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".
    • Rename AssetsContractController method getERC721CollectibleTokenId to getERC721NftTokenId.
    • Rename assetsUtil method compareCollectiblesMetadata to compareNftMetadata.
    • Rename constant ASSET_TYPES.COLLECTIBLE to ASSET_TYPES.NFT
    • Rename PreferencesController state property useCollectibleDetection to useNftDetection
    • Rename PreferenceController method setUseCollectibleDetection to setUseNftDetection

Fixed

  • Fix NetworkController lookupNetwork deadlock (#948)
  • Fix invalid rpcTarget and nickname network state after switching from custom network to Infura network using setProviderType (#947)
Changelog

Sourced from @​metamask/controllers's changelog.

[33.0.0]

Added

  • Add clear function for NotificationController (#943)

Changed

  • BREAKING: Rename "Collectible" to "NFT" (#934)
    • Rename CollectiblesController to NftController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".
    • Rename CollectibleDetectionController to NftDetectionController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".
    • Rename AssetsContractController method getERC721CollectibleTokenId to getERC721NftTokenId.
    • Rename assetsUtil method compareCollectiblesMetadata to compareNftMetadata.
    • Rename constant ASSET_TYPES.COLLECTIBLE to ASSET_TYPES.NFT
    • Rename PreferencesController state property useCollectibleDetection to useNftDetection
    • Rename PreferenceController method setUseCollectibleDetection to setUseNftDetection

Fixed

  • Fix NetworkController lookupNetwork deadlock (#948)
  • Fix invalid rpcTarget and nickname network state after switching from custom network to Infura network using setProviderType (#947)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@metamask/controllers](https://github.com/MetaMask/controllers) from 32.0.2 to 33.0.0.
- [Release notes](https://github.com/MetaMask/controllers/releases)
- [Changelog](https://github.com/MetaMask/controllers/blob/main/CHANGELOG.md)
- [Commits](MetaMask/core@v32.0.2...v33.0.0)

---
updated-dependencies:
- dependency-name: "@metamask/controllers"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner November 9, 2022 06:09
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 9, 2022
@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
[email protected] (added) postinstall package.json via @metamask/[email protected], [email protected]
Pull request report summary
Issue Status
Install scripts ⚠️ 1 issue
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@FrederikBolding
Copy link
Member

Closing after merging #110

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 30, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@FrederikBolding FrederikBolding deleted the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch November 30, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant