Emit an event with a Smart Transaction before confirmation (#333)

MetaMask · May 9, 2024 · 5100ea3 · 5100ea3
1 parent 69a7455
commit 5100ea3
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/SmartTransactionsController.ts b/src/SmartTransactionsController.ts
@@ -394,6 +394,13 @@ export default class SmartTransactionsController extends StaticIntervalPollingCo
       return;
     }
 
+    // We have to emit this event here, because then a txHash is returned to the TransactionController once it's available
+    // and the #doesTransactionNeedConfirmation function will work properly, since it will find the txHash in the regular transactions list.
+    this.eventEmitter.emit(
+      `${smartTransaction.uuid}:smartTransaction`,
+      smartTransaction,
+    );
+
     if (
       (smartTransaction.status === SmartTransactionStatuses.SUCCESS ||
         smartTransaction.status === SmartTransactionStatuses.REVERTED) &&
@@ -426,11 +433,6 @@ export default class SmartTransactionsController extends StaticIntervalPollingCo
         },
       });
     }
-
-    this.eventEmitter.emit(
-      `${smartTransaction.uuid}:smartTransaction`,
-      smartTransaction,
-    );
   }
 
   async updateSmartTransactions({