Allow passing unknown values as cause #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only the `Error` type as accepted as cause, but since any value can be thrown as error, we have to allow any value to be used.
| const error = rpcErrors.invalidInput({ | ||
| data: { | ||
| foo: 'bar', | ||
| cause: 'foo', |
There was a problem hiding this comment.
What happens when this is not JSON-serializable?
3 tasks
FrederikBolding
previously approved these changes
Apr 19, 2023
legobeat
approved these changes
Apr 19, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to enable unknown values to be used as the cause of an error. Previously, only the
Errortypewas allowed as a cause of error. However, any value may cause an error to occur, not just an
Errorvalue. Therefore,it becomes necessary to allow other types to be used as error causes.
Changes