Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated properties warning #360

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Sep 6, 2024

Removes deprecation warnings for window.ethereum.chainId, window.ethereum.networkVersion, and window.ethereum.selectedAddress when accessed for the first time after page load

@jiexi jiexi requested a review from a team as a code owner September 6, 2024 21:48
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiexi jiexi merged commit 1f047a2 into main Sep 6, 2024
18 checks passed
@jiexi jiexi deleted the jl/mmp-3233/remove-chainId-networkVersion-selectedAddress-deprecation-warning branch September 6, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants