adding edge-chromium support for createExternalExtensionProvider #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @jhonnyV-V ! Looks good to me, guess we should test it too for good measure. I left some review suggestions to bring the meta-related stuff in line with expectations. |
legobeat
reviewed
May 16, 2024
Co-authored-by: legobeat <[email protected]>
Co-authored-by: legobeat <[email protected]>
|
Great, I accepted the suggestions, @legobeat |
mcmire
reviewed
Jun 27, 2024
Change link to file to link to pr Co-authored-by: Elliot Winkler <[email protected]>
legobeat
previously approved these changes
Sep 23, 2024
legobeat
previously approved these changes
Sep 23, 2024
legobeat
force-pushed
the
fix/external-extension-edge
branch
from
208fd46 to
6e3a5a1
Compare
legobeat
approved these changes
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the Metamask stable extension ID is different in edge-chromium, this make the createExternalExtensionProvider function fail on edge, I just added a new field in the JSON with the correct ID and changed the way the ID is retrieved
This is my first pull request to any Metamask repo, and the changelog part was not clear to me, should I leave the changes under a version or under unreleased?.
Any feedback is helpful