Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix deprecated webextension-polyfill-ts #249

Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore: fix deprecated webextension-polyfill-ts #249

merged 1 commit into from
Mar 30, 2023

Conversation

zouhangwithsweet
Copy link
Contributor

fix: #242 #224

@zouhangwithsweet zouhangwithsweet requested a review from a team as a code owner March 30, 2023 03:59
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@types/[email protected] None +0 types

🚮 Removed packages: [email protected]

Gudahtt
Gudahtt approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Gudahtt Gudahtt merged commit a6c77a4 into MetaMask:main Mar 30, 2023
This was referenced Mar 30, 2023
Closed
Open
@legobeat legobeat mentioned this pull request May 10, 2023
Merged
legobeat added a commit to legobeat/providers that referenced this pull request May 10, 2023
@legobeat
move @types/ packages from deps to devDeps
821d1cd 
Originally introduced in:
- MetaMask#152
- MetaMask#249
legobeat added a commit that referenced this pull request May 10, 2023
@legobeat
move @types/ packages from deps to devDeps (#259)
41baf7f 
Originally introduced in:
- #152
- #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ WARN  deprecated webextension-polyfill-ts
2 participants
@zouhangwithsweet @Gudahtt