Only emit state change events after initialization #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, after merge conflicts @rekmarks |
rekmarks
commented
Dec 7, 2020
brad-decker
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported in #110 that
chainChanged(and by extension,networkChanged) is sometimes emitted for the first time after page load, causing a reload loop for those handling chain changes by reloading the page. When thechainIdis set on initialization, the chain has not changed, andchainChangedshould not be emitted. The same can be said foraccountsChanged, which currently would emit under the same circumstances.This PR ensures that
chainChanged,networkChanged, andaccountsChangedare only emitted after the provider has been initialized.Fixes #110