Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript migration changes for obj-multiplex #9

Merged
merged 7 commits into from
Dec 7, 2020
Merged

Typescript migration changes for obj-multiplex #9

merged 7 commits into from
Dec 7, 2020

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Dec 1, 2020 •
edited by rekmarks
Loading

I have added comments regarding a few doubts I have while migrating.

Closes #8

@NiranjanaBinoy NiranjanaBinoy linked an issue Dec 1, 2020 that may be closed by this pull request
Migrating obj-multiplex to typescript #8
Closed
NiranjanaBinoy
NiranjanaBinoy commented Dec 1, 2020
View reviewed changes
src/ObjectMultiplex.ts Outdated Show resolved Hide resolved
@NiranjanaBinoy NiranjanaBinoy marked this pull request as ready for review December 1, 2020 18:27
rekmarks
rekmarks requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Here's one more request, in addition to the inline comments:

  • Add an appropriate LICENSE file per package.json. You can just copy the file from a different repository. The copyright year should be 2020.

.circleci/config.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/ObjectMultiplex.ts Outdated Show resolved Hide resolved
src/ObjectMultiplex.ts Outdated Show resolved Hide resolved
src/ObjectMultiplex.ts Outdated Show resolved Hide resolved
src/Substream.ts Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
rekmarks
rekmarks reviewed Dec 6, 2020
View reviewed changes
src/ObjectMultiplex.ts Outdated Show resolved Hide resolved
rekmarks
rekmarks approved these changes Dec 6, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@NiranjanaBinoy NiranjanaBinoy merged commit 77381a0 into master Dec 7, 2020
@rekmarks rekmarks deleted the typescript-obj-multiplex branch December 7, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrating obj-multiplex to typescript
2 participants
@NiranjanaBinoy @rekmarks