Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow overriding default stream constructor options #52

Merged
merged 3 commits into from
May 15, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 15, 2024

  • feat: Add optional opts parameter to createStream. Any option set here will be forwarded to the underlying Substream constructor
  • feat: Substream now recognizes stream constructor options. Any option set here will be forwarded to the underlying Duplex constructor
  • fix: objectMode stream option can now be overriden like any other option
  • feat: Use more specific type DuplexOptions for ObjectMultiplex constructor

@legobeat legobeat merged commit a9ad889 into MetaMask:main May 15, 2024
8 checks passed
@legobeat legobeat deleted the stream-options branch May 15, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants