Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0.0 #46

Merged
merged 1 commit into from
Oct 25, 2023
Merged

v2.0.0 #46

merged 1 commit into from
Oct 25, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 24, 2023 •
edited
Loading

Changed

  • BREAKING: Increase minimum Node.js version to 16 (#41)
  • BREAKING: Bump readable-stream from ^2.3.3 to 3.6.2 (#41)

Removed

  • Remove dependency end-of-stream (#41)
  • Remove stream-resolved.finished overload in types (#41)

Resolves

Blocked by

@socket-security
Copy link

socket-security bot commented Oct 24, 2023 •
edited
Loading

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@socket-security
Copy link

socket-security bot commented Oct 24, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat legobeat mentioned this pull request Oct 24, 2023
Closed
1 task
@legobeat legobeat marked this pull request as ready for review October 25, 2023 09:56
@legobeat legobeat requested a review from a team as a code owner October 25, 2023 09:56
Mrtenz
Mrtenz reviewed Oct 25, 2023
View reviewed changes
CHANGELOG.md
## [2.0.0]
### Changed
- **BREAKING**: Increase minimum Node.js version to 16 ([#41](https://github.com/MetaMask/object-multiplex/pull/41))
- **BREAKING**: Bump `readable-stream` from `^2.3.3` to `3.6.2` ([#41](https://github.com/MetaMask/object-multiplex/pull/41))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this breaking?

Copy link
Contributor Author

@legobeat legobeat Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this instantiates and interfaces with streams, should be the same for streamsv3 API: https://www.npmjs.com/package/readable-stream#version-3xx

It corresponds to the same as a bump from nodejs v8 to v10 would do for native streams.

@legobeat legobeat merged commit bce91d7 into main Oct 25, 2023
5 checks passed
@legobeat legobeat deleted the release/2.0.0 branch October 25, 2023 18:17
@legobeat
Copy link
Contributor Author 

npm notice package: @metamask/[email protected]
npm notice === Tarball Contents ===
npm notice 739B  LICENSE
npm notice 1.9kB README.md
npm notice 79B   dist/index.d.ts
npm notice 155B  dist/index.js
npm notice 137B  dist/index.js.map
npm notice 513B  dist/ObjectMultiplex.d.ts
npm notice 3.1kB dist/ObjectMultiplex.js
npm notice 2.3kB dist/ObjectMultiplex.js.map
npm notice 837B  dist/Substream.d.ts
npm notice 968B  dist/Substream.js
npm notice 583B  dist/Substream.js.map
npm notice 1.8kB package.json
npm notice === Tarball Details ===
npm notice name:          @metamask/object-multiplex
npm notice version:       2.0.0
npm notice filename:      @metamask/object-multiplex-2.0.0.tgz
npm notice package size:  4.8 kB
npm notice unpacked size: 13.2 kB
npm notice shasum:        aa6e4aa7b4e2f457ea4bb51cd7281d931e0aa35d
npm notice integrity:     sha512-+ItrieVZie3j2[...]AGRwJUA9BMrqA==
npm notice total files:   12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @Mrtenz