Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw error if parent is destroyed already when creating sub streams #17

Merged
merged 3 commits into from
Jun 1, 2021
Merged

throw error if parent is destroyed already when creating sub streams #17

merged 3 commits into from
Jun 1, 2021

Conversation

shanejonas
Copy link
Contributor

No description provided.

@shanejonas shanejonas requested a review from a team as a code owner May 28, 2021 22:45
Gudahtt
Gudahtt previously approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shanejonas shanejonas requested a review from Gudahtt May 31, 2021 23:50
Gudahtt
Gudahtt reviewed Jun 1, 2021
View reviewed changes
test/index.js Outdated Show resolved Hide resolved
@shanejonas @Gudahtt
Update test/index.js
93deea1 
Co-authored-by: Mark Stacey <[email protected]>
@shanejonas shanejonas requested a review from Gudahtt June 1, 2021 02:36
@Gudahtt Gudahtt merged commit 74b80c1 into main Jun 1, 2021
@Gudahtt Gudahtt deleted the throw-error-on-destroyed branch June 1, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks left review comments

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanejonas @Gudahtt @rekmarks