Feature: ERC20 approve #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
added
the
needs-qa
brunobar79
approved these changes
Aug 15, 2019
| @@ -461,7 +461,8 @@ | |||
| "cancel_tx_title": "Attempt to cancel?", | |||
| "cancel_tx_message": "Submitting this attempt does not guarantee your original transaction will be cancelled. If the canellation attempt is successful, you will be charged the transaction fee above.", | |||
| "nevermind": "Nevermind", | |||
| "gasCancelFee": "Gas Cancellation Fee" | |||
| "gasCancelFee": "Gas Cancellation Fee", | |||
| "approve_warning": "By approving this action, you grant permission for this contract to spend up to" | |||
There was a problem hiding this comment.
this is what we're saying on the extension 🤷♂
| @@ -453,7 +453,8 @@ | |||
| "value_not_available": "No disponible", | |||
| "rate_not_available": "Conversión no disponible", | |||
| "optional": "Opcional", | |||
| "no_address_for_ens": "No existe dirección para nombre ENS" | |||
| "no_address_for_ens": "No existe dirección para nombre ENS", | |||
| "approve_warning": "Al aprobar esta acción, otorgas permiso para que este contrato gaste hasta" | |||
|
Perhaps make the warning text align left instead of justified Smaller screen view:
|
ibrahimtaveras00
approved these changes
Aug 16, 2019
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* rm unnecessary code * mv calculations to didmount instead of render * render approve info * render alert * fix missing locales * render contract information * delete empty * snaps * left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
transaction.optionalChecklist
Issue
Resolves #809