Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: instapay global currency #992

Merged
merged 8 commits into from
Aug 15, 2019
Merged

Feature: instapay global currency #992

merged 8 commits into from
Aug 15, 2019

Conversation

estebanmino
Copy link
Contributor

Description

This pr adds global currency behavior to instapay

  • In send, users can now switch currency
  • Instapay main view renders balance according to global and primary currency
  • Instapay deposit now works according to primary currency. I think we could add a switch in the future as we do for all other send views, I didn't add it now because of designs are different here.

Fo3GJNwrs5

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #981

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 9, 2019
brunobar79
brunobar79 approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both Android and iOS, both small and big screens, QA Passed 👍

@estebanmino estebanmino merged commit fffdc02 into develop Aug 15, 2019
@estebanmino estebanmino deleted the feature/instapay-global-currency branch August 20, 2019 18:04
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Feature: instapay global currency (#992)
345571a 
* switch currency send instapay

* update balancefiat when changing currency

* listen global currency

* card too

* snaps

* value

* qa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InstaPay should listen to global currency settings
3 participants
@estebanmino @brunobar79 @ibrahimtaveras00