Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade address-book-controller #9805

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented May 30, 2024

Description

Updating the address-book-controller from v3.0.0 to 4.0.1

Related issues

Fixes: #1778

Manual testing steps

  1. Go to address, click on edit
  2. Insert nickname (label) for the address
  3. Make sure that the label shows up when you try sending to said address

Screenshots/Recordings

No changes (videos show identical functionality)

Before

address-book-before.mov

After

address-book-after.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@kylanhurt kylanhurt requested a review from a team as a code owner May 30, 2024 15:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kylanhurt kylanhurt added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels May 30, 2024
Copy link

socket-security bot commented May 30, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: filesystem +7 2.21 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

Copy link
Contributor

github-actions bot commented May 30, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8654c7e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/663a5a45-a1f5-40b8-bae7-23fef88401bb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@tommasini
Copy link
Contributor

tommasini commented May 31, 2024

Oh wait, The e2e are failing, can you update with main and re-run those?

@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 31, 2024
Copy link
Contributor

github-actions bot commented May 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 78f1a48
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/feac3f0d-1c4b-4e74-859e-f5001b12b11a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kylanhurt kylanhurt merged commit 9e45292 into main Jun 3, 2024
35 checks passed
@kylanhurt kylanhurt deleted the kylan/address-book-controller branch June 3, 2024 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
@metamaskbot metamaskbot added the release-7.25.0 Issue or pull request that will be included in release 7.25.0 label Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.25.0 Issue or pull request that will be included in release 7.25.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants