-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade address-book-controller #9805
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Bitrise❌❌❌ Commit hash: 8654c7e Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM!
Oh wait, The e2e are failing, can you update with main and re-run those? |
Bitrise✅✅✅ Commit hash: 78f1a48 Note
|
Quality Gate passedIssues Measures |
Description
Updating the
address-book-controller
from v3.0.0 to 4.0.1Related issues
Fixes: #1778
Manual testing steps
Screenshots/Recordings
No changes (videos show identical functionality)
Before
address-book-before.mov
After
address-book-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist