Bugfix: ExceptionsManagerModule android crashes #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
added
the
needs-qa
estebanmino
changed the title
ibrahimtaveras00
approved these changes
Jul 30, 2019
brunobar79
approved these changes
Jul 30, 2019
| selectedAddress, | ||
| identities | ||
| } = this.props; | ||
| const host = getHost(url); | ||
| const title = typeof currentPageInformation.title === 'string' ? currentPageInformation.title : getHost(url); |
There was a problem hiding this comment.
I literally made this change last night and it didn't go to production yet.
See https://github.com/MetaMask/metamask-mobile/pull/963/files#diff-6b966e9916d92d54ae676b69d898840cR244
There was a problem hiding this comment.
yes, title was the problem not host. I was able to get to some cases where title was {} making everything crash
| const { url } = this.props; | ||
| const apiLogoUrl = { uri: this.getIconUrl(url) }; | ||
| const title = typeof this.props.title === 'string' ? this.props.title : getHost(url); | ||
| this.setState({ title: title.substring(0, 1).toUpperCase(), apiLogoUrl }); |
There was a problem hiding this comment.
I oppose to this change because it's gonna cause an extra re-render in every website icon, no matter if it was problematic or not.
My suggestion is to can keep those in the render method and use the this prop to capitalize: https://facebook.github.io/react-native/docs/text-style-props#texttransform
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* issue 1 * more like issue 1 * fix website icon * animations * rm code * comment * rm state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are the top 3 crashes on android, for
ExceptionsManagerModulecategory, fixed on this prfirst (by far)
https://www.fabric.io/metamask/android/apps/io.metamask/issues/5c3f843bf8b88c29637fb4f9/sessions/5D405282008500011CF1A9854DAEE5E9_DNE_0_v2?build=109182544
SignatureRequest, AccountApproval and UrlAutocomplete were affected by this. I was able to reproduce
Second
https://www.fabric.io/metamask/android/apps/io.metamask/issues/5c3f843bf8b88c29637fb4f9/sessions/5D4036180382000157165E3FD372E7A3_DNE_3_v2?build=109182544
https://www.fabric.io/metamask/android/apps/io.metamask/issues/5c3f843bf8b88c29637fb4f9/sessions/5D3F22C7032800016AD24492C2822C5C_DNE_2_v2?build=109182544
For this one i just checked if animation refs were defined, if not just skip the animation and go continue the flow. I wasn't able to reproduce
third https://www.fabric.io/metamask/android/apps/io.metamask/issues/5c3f843bf8b88c29637fb4f9/sessions/5D3FD42200EB00016EDBA9854DAEE5E9_DNE_0_v2?build=109182544
Website icon bug where url wasn't defined.
Checklist
Issue
Resolves #???