-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent bad svg urls in react-native-svg #8102
fix: prevent bad svg urls in react-native-svg #8102
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8102 +/- ##
=======================================
Coverage 39.39% 39.39%
=======================================
Files 1220 1220
Lines 29800 29800
Branches 2831 2831
=======================================
Hits 11740 11740
Misses 17371 17371
Partials 689 689 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6fe0214-706d-4752-a969-087d40f47249 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Some dapps had bad icon urls in their metadata which prevented rendering favicon properly. This PR adds a patch to react-native-svg to prevent trying to render invalid svg urls.
Related issues
Fixes: #1431
Manual testing steps
Screenshots/Recordings
WC connect to site with bad meta url
svg-wc.mp4
Search Bar icons
svg-search.mp4
Tab Bar icons
svg-tabs.mp4
Pre-merge author checklist
Pre-merge reviewer checklist